Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce lang list size to fix overflow #61

Merged
merged 2 commits into from
Jun 30, 2024
Merged

Conversation

kshannoninnes
Copy link

A scrollbar was getting introduced due to the size of the langs list. This reduces the size from 23 options to 17 options, and also adjusts some height attributes in other elements to remove the scrollbar completely.

@matze
Copy link
Owner

matze commented Jun 29, 2024

I think the removal of one of the margins caused this imbalance between paste content and language list:

Bildschirmfoto vom 2024-06-30 00-57-26

@kshannoninnes
Copy link
Author

kshannoninnes commented Jun 29, 2024

Odd. What browser are you using? I just tested firefox chrome and edge and they're all spaced out appropriately. Am I misunderstanding what you mean? Could it be related to the difference between light and dark theme? I didn't touch any of those, but also haven't looked too closely at how they work.

Edit: Wait I think I know what you mean. I removed the top margin, but added a top padding to the extensions-list, but didn't add it to the paste text area div.

(Also just realized I haven't fixed the scrollbar for the latter 2 browsers so will do that really quickly)
image

@matze
Copy link
Owner

matze commented Jun 30, 2024

I also see it in your screenshot. The <paste text or drop file here> moved up a bit, the padding was on purpose and also matched the first line of the lang list.

@kshannoninnes
Copy link
Author

Yeah I realized later on what you were referring to (in the edit of my last reply) and pushed the fix before your comment :)

@matze
Copy link
Owner

matze commented Jun 30, 2024

Looks, good, thanks!

@matze matze merged commit 862bf29 into matze:master Jun 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants