Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Frontend: 2FA improvements #2

Conversation

odeimaiz
Copy link

@odeimaiz odeimaiz commented Apr 15, 2024

What do these changes do?

  • Expose twoFAPreference setting only when webserverLogin.LOGIN_2FA_REQUIRED is set to True
  • Show warning message when the user want to disable the 2FA
  • Reduce resend-code via different method to 20"
  • Support user's code-via-email preference when logging in
  • Stop using deprecated fields

1a. First Log in and skip phone registration
FirstTimeLogIn

1b. First Log in and register phone
FirstTimeLogInAndPhone

2a. Log In with Preferred method: SMS default
LogInSms

2b. Log In with Preferred method: Email
LogInEmail

2c. Log In with Preferred method: Disabled
LogInDisabled

3 Alternative to the Preferred method
Alternative

Related issue/s

Frontend for ITISFoundation#5668

How to test

Dev-ops checklist

@odeimaiz odeimaiz changed the title Odeimaiz is1315/2fa improvements ✨ Frontend: 2FA improvements Apr 15, 2024
@odeimaiz odeimaiz marked this pull request as ready for review April 16, 2024 14:19
@matusdrobuliak66 matusdrobuliak66 merged commit d911fc1 into matusdrobuliak66:is1315/2fa-improvements Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants