allow '=' in query parameter value

mattwhisenhunt · Feb 15, 2018 · 356bf78 · 356bf78
1 parent 943aa99
commit 356bf78
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/google-http-client/src/main/java/com/google/api/client/http/UrlEncodedParser.java b/google-http-client/src/main/java/com/google/api/client/http/UrlEncodedParser.java
@@ -196,8 +196,13 @@ public static void parse(Reader reader, Object data) throws IOException {
           }
           break;
         case '=':
-          // finished with name, now read value
-          readingName = false;
+          if (readingName) {
+            // finished with name, now read value
+            readingName = false;
+          } else {
+            // '=' is in the value
+            valueWriter.write(read);
+          }
           break;
         default:
           // read one more character

diff --git a/google-http-client/src/test/java/com/google/api/client/http/UrlEncodedParserTest.java b/google-http-client/src/test/java/com/google/api/client/http/UrlEncodedParserTest.java
@@ -112,9 +112,9 @@ public Generic set(String fieldName, Object value) {
   public void testParse_simple() {
     Simple actual = new Simple();
     UrlEncodedParser.parse(
-        "v=ignore&v=ignore2&q=1&a=x&b=y&c=z&q=2&undeclared=0&o=object&r=a1&r=a2", actual);
+        "v=ignore&v=ignore2&q=1&a=x=&b=y&c=z&q=2&undeclared=0&o=object&r=a1&r=a2", actual);
     Simple expected = new Simple();
-    expected.a = "x";
+    expected.a = "x=";
     expected.b = "y";
     expected.c = "z";
     expected.q = new ArrayList<String>(Arrays.asList("1", "2"));