Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for banner-style images to episode page #60

Closed
mattstratton opened this issue Apr 27, 2017 · 3 comments
Closed

Add support for banner-style images to episode page #60

mattstratton opened this issue Apr 27, 2017 · 3 comments
Assignees

Comments

@mattstratton
Copy link
Owner

In order for this to work for arrested devops, we need to support banner images on episode pages.

For example:

My thought is to add an optional frontmatter to the episode, like this:

episode_banner = "/img/episode/mybanner.jpg"

If this is set, then the single episode template would display the banner across the top instead of the square image, and put the description below it.

@mattstratton mattstratton added this to the v.1.0 milestone Apr 27, 2017
@rpodcast
Copy link
Contributor

I wonder if that would also be possible on the site home page too? Not a huge deal but just something to consider.

@mattstratton
Copy link
Owner Author

@Thercast that would definitely be a good addition, and I don't see why not.

Are you thinking that it would only be for the hero at the top, or for each episode?

The main reason I suspect I would rather have it only be for the hero, is because you might have some episodes with and some without, and it would look odd for the episodes that are the "same" (i.e., not the "latest") to look different from each other.

@rpodcast
Copy link
Contributor

rpodcast commented May 1, 2017

@mattstratton you are right. I was thinking for only the hero at the top and I wouldn't want the inconsistency between the latest and non-latest episode views.

mattstratton added a commit that referenced this issue May 3, 2017
@ghost ghost assigned mattstratton May 3, 2017
@ghost ghost added the in progress label May 3, 2017
@ghost ghost removed the in progress label May 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants