Update to async-std 1.9, change UDP stream implementation #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The poll_next method of UdpFramed needs to store the socket.recv_from future, the old behavior of recreating the future on each poll is no longer supported. See [this issue](async-rs/async-std#955) for details. - I couldn't get the future to work with BytesMut because all references or raw pointers seem to be not Send which is needed for it to work across the await. Thus I changed to a vec, which should be fine too, but not sure.
|
Likely the same should be done for the |
|
I changed the poll_flush implementation to also store the future and not recreate it on each poll. The clippy and rustfmt fails are unrelated AFAICS. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the async-std dependency from
1.6.2to1.9. The update initially broke reading from the UDP socket. A fix is included in this PR.socket.recv_fromfuture, the old behavior of recreating the future on each poll is no longer supported by async_std.
See this issue
for details.