[Based on #195 but zero-copy] Log ws message on parsing error to Message enum #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
requested changes
Feb 14, 2024
src/conn.rs
Outdated
Comment on lines
158
to
159
| // ignore pings | ||
| Poll::Pending |
There was a problem hiding this comment.
we might still have more work to do so we either need to wake here before returning pending are put the ws poll in a loop
There was a problem hiding this comment.
Thanks, i've fixed it!
|
Is it safe to ignore the bytes and frames though? |
mattsse
approved these changes
Feb 14, 2024
Ignoring Frame is safe because we should not get it when reading a message as snapview/tungstenite-rs#250. IMO ignoring Bytes is also safe because cdp is a JSON-based protocol and I suppose it uses only the text type of frame. |
|
CDP actually can stream the responses - which would suggest using the advanced websocket capabilities - but I checked and it indeed only uses text with data embedded as base64. See: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title, this is based on #195, but zero-copy.
Also, it changes from doing
serde_json::from_slice(&data.into_data())to doingserde_json::from_str(&text)ofWsMessage::Text(text). Other variants ofWsMessageare handled as follows:PingandPong: IgnoredBytesandFrames: IgnoredClose: Ends the stream