Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a bug. The
wrap
method was being sent:success
,:pending
, and:failure
keys. Since those keys don't exist in theVT100_CODES
hash, all the scoreboard values were displaying in the default white.I also simplified the logic for fetching color codes because I noticed the following two issues:
console_code_for(:white)
will result in infinite recursion if the:white
key doesn't exist in theVT100_CODES
hash.console_code_for
method had logic to allow the caller to send the actual color code instead of a symbol. However, I cannot find any place where a color code is sent to that method, so the added complexity of that logic seemed unnecessary.