Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoreboard colors #75

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wyattisimo
Copy link
Contributor

I noticed a bug. The wrap method was being sent :success, :pending, and :failure keys. Since those keys don't exist in the VT100_CODES hash, all the scoreboard values were displaying in the default white.

I also simplified the logic for fetching color codes because I noticed the following two issues:

  1. The recursive call console_code_for(:white) will result in infinite recursion if the :white key doesn't exist in the VT100_CODES hash.
  2. The console_code_for method had logic to allow the caller to send the actual color code instead of a symbol. However, I cannot find any place where a color code is sent to that method, so the added complexity of that logic seemed unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant