Cleanup Javadoc for HystrixCommandMetrics

mattrjacobs · Jul 30, 2015 · dfb2be6 · dfb2be6
1 parent 17d37e6
commit dfb2be6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/hystrix-core/src/main/java/com/netflix/hystrix/HystrixCommandMetrics.java b/hystrix-core/src/main/java/com/netflix/hystrix/HystrixCommandMetrics.java
@@ -414,6 +414,9 @@ public long getRollingMaxConcurrentExecutions() {
 
     /**
      * Retrieve a snapshot of total requests, error count and error percentage.
+     *
+     * Marked final so that concrete implementation may vary how to implement {@link #getRollingCount(HystrixRollingNumberEvent)}
+     * and the health check (used for opening a {@link HystrixCircuitBreaker} is constant
      * 
      * @return {@link HealthCounts}
      */

diff --git a/...core/src/main/java/com/netflix/hystrix/strategy/metrics/HystrixCommandMetricsSummary.java b/...core/src/main/java/com/netflix/hystrix/strategy/metrics/HystrixCommandMetricsSummary.java
@@ -79,10 +79,6 @@ protected void updateRollingMax(HystrixRollingNumberEvent event, long value) {
         counter.updateRollingMax(event, value);
     }
 
-    public long getRollingMaxConcurrentExecutions() {
-        return counter.getRollingMaxValue(HystrixRollingNumberEvent.COMMAND_MAX_ACTIVE);
-    }
-
     /**
      * Execution time of {@link HystrixCommand#run()}.
      */