Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip installation checks for clangd server if it has already been set up locally. #778

Merged

Conversation

EugeneSqr
Copy link
Contributor

In Arch Linux clangd comes as a part of the clang package.

After successful installation the binaries are placed into /usr/bin like this:

lrwxrwxrwx 1 root root       8 Oct  3 19:11 clang -> clang-18
-rwxr-xr-x 1 root root    143K Oct  3 19:11 clang-18
-rwxr-xr-x 1 root root     25M Oct  3 19:11 clangd
-rwxr-xr-x 1 root root     99K Oct  3 19:11 clang-format
...

which makes clangd readily available:

$ clangd --version
clangd version 18.1.8
Features: linux
Platform: x86_64-pc-linux-gnu

Currently the clangd LSP server installation script expects local clangd binaries to be named like "clangd-X", which isn't always the case as shown above. This aborts LSP server installation with the following message "Could not find an installable clangd release!"

This PR bypasses the check when clangd is set up allowing LSP server installation to complete successfully.

@EugeneSqr EugeneSqr force-pushed the fix_clangd_installation_with_local_clang branch from 61c7d60 to 4c974d8 Compare October 21, 2024 16:22
@EugeneSqr EugeneSqr force-pushed the fix_clangd_installation_with_local_clang branch from 4c974d8 to 257871b Compare October 21, 2024 17:07
@mattn mattn merged commit e608a9d into mattn:master Oct 21, 2024
14 checks passed
@mattn
Copy link
Owner

mattn commented Oct 21, 2024

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants