Update Volar (currently called Vue Language Tools) to v2.0 #728
Conversation
| @@ -1,3 +1,38 @@ | |||
| function! s:find_vue_plugin() abort | |||
| let package_json_path = lsp#utils#find_nearest_parent_file(lsp#utils#get_buffer_path(), 'package.json') | |||
There was a problem hiding this comment.
[ask]
What happens if there is vue in the root package.json In monorepo?
It would be nice if users could inject the location of package.json(global variable or can get from lsp_settings#get()?
There was a problem hiding this comment.
Thank you for your feedback! I couldn't consider that…
What I want to do is enabling @vue/typescript-plugin only in Vue projects, but I don't come up with an idea to detect Vue projects even in monorepo situation 🤔
Now I'm wondering if @vue/typescript-plugin is always enabled when it exists, since it doesn't have bad side effects (might have small performance degradation, though).
There was a problem hiding this comment.
I modified to use @vue/typescript-plugin when it just exists 983dc16 .
I think that this still has small side effect to all users since only Vue users will install volar-server.
|
@heavenshell any opinion? |
|
@mattn I'm sorry did not notice your mention. |
|
Thank you |
Vue Language Tools v2.0 consists of the
@vue/language-serverand@vue/typescript-plugin.g:lsp_settings_filetype_vuesetup instruction to enable bothvolar-serverandtypescript-language-serverinvuefiletype.@vue/typescript-plugintotypescript-language-serverplugins only in Vue projects.I think this is the first case to utilize typescript language server's plugins in vue-lsp-setttings.
So, I would like to have advice if my approach to do that is not appropriate.