fix trying to parse subshell calls as env vars #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parser didn't detect subshell calls, $(), and tried to parse them as environment variables. This picks up the $( pattern and continues on with parsing, leaving it as is. Added tests for it as well.
Codecov Report
@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 89.62% 89.81% +0.19%
==========================================
Files 3 3
Lines 212 216 +4
==========================================
+ Hits 190 194 +4
Misses 15 15
Partials 7 7
Continue to review full report at Codecov.
|
|
I'm re-looking at this as it doesn't seem like the tests are as good as they should be. Mainly that the $() syntax should be treated like the `` (backtick) syntax more thoroughly in the tests. |
|
I'm just going to close this PR and re-figure this out. This "fix" doesn't play well with the normal command (backtick) parsing and running. I'll re-submit when I have something better. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parser didn't detect subshell calls,$(), and tried to parse them as environment variables. This picks up the $ ( pattern and continues on with parsing, leaving it as is.
Added tests for it as well.