-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust build tags to allow building on tinygo; for #73. #74
Conversation
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
=======================================
Coverage 44.00% 44.00%
=======================================
Files 3 3
Lines 75 75
=======================================
Hits 33 33
Misses 40 40
Partials 2 2
Continue to review full report at Codecov.
|
Hi @mattn is it possible to get this merged so that we can use this with tinygo? |
could you please fix conflict? |
9bb614f
to
13f3590
Compare
Hi @dkegel-fastly thank you for fixing the conflict. @mattn over to you now :), thank you so much. |
Hi @mattn , a kind reminder. thank you. |
a kind reminder @mattn, thank you. |
Hi @mattn , a kind reminder to kindly review the PR. once merged, it will allow folks, using tinygo, to stop using the fork. many thanks in advance. |
Yes, please! |
tinygo-0.28 is coming out shortly, which will bring more users hoping for this fix, I think! |
Hi @mattn, another request to merge @dkegel-fastly’s PR. Ran into this issue today with TinyGo. Many thanks! |
thanks |
Passes "tinygo test" on macos and linux.
Passes cross test to windows from macos, i.e. "GOOS=windows tinygo test -c; wine64 go-isatty.test".
Had to adjust the build tags on isatty_others.go to avoid multiple definition link failure on