Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add GetValueSymbols and GetTypeSymbols #347

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

issadarkthing
Copy link

@issadarkthing issadarkthing commented Mar 21, 2021

I've been using anko for my music player and I wanted to implement auto completion. By adding GetValueSymbols and GetTypeSymbols, I will be able to easily fetch symbols of the current scope. This will also help others with the same use case.

@codecov-io
Copy link

codecov-io commented Mar 21, 2021

Codecov Report

Merging #347 (2607b99) into master (0d30f07) will decrease coverage by 0.75%.
The diff coverage is 50.00%.

❗ Current head 2607b99 differs from pull request most recent head e4c5376. Consider uploading reports for the commit e4c5376 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #347      +/-   ##
==========================================
- Coverage   88.40%   87.64%   -0.76%     
==========================================
  Files          15       15              
  Lines        2682     2550     -132     
==========================================
- Hits         2371     2235     -136     
- Misses        201      205       +4     
  Partials      110      110              
Impacted Files Coverage Δ
env/envValues.go 93.75% <50.00%> (-6.25%) ⬇️
ast/astutil/walk.go 42.85% <0.00%> (-3.26%) ⬇️
vm/vmToX.go 84.69% <0.00%> (-1.29%) ⬇️
vm/vmExprFunction.go 75.76% <0.00%> (-1.16%) ⬇️
anko.go 67.44% <0.00%> (-1.04%) ⬇️
vm/vm.go 91.26% <0.00%> (-0.67%) ⬇️
vm/vmConvertToX.go 93.33% <0.00%> (-0.55%) ⬇️
vm/vmStmt.go 96.01% <0.00%> (-0.19%) ⬇️
vm/vmExpr.go 96.20% <0.00%> (-0.09%) ⬇️
vm/vmLetExpr.go 85.71% <0.00%> (-0.06%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d30f07...e4c5376. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants