added check for ignoreSourceMap option #64
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Matt. I am using the Karma Istanbul Reporter for an Angular 6 project with multiple custom projects/libraries. The projects import modules from each other, which come from the dist folder of the library. When run on a given project, the reporter would give the stats on the files in the dist folders of the libraries that are dependencies of the project being tested. The reporter was using the source-maps in these libraries to try to break down the tests to their sources, but it was generating paths that included "ng:", which resulted in an error on my Windows machine, since "ng:" is an invalid directory name. I do not really care about these source mappings for my purposes, and because it was causing this error, I created an option to ignore the source mappings.
I know the code I am submitting for this review may need further work, etc., but I figured this was the best way of reaching you with this feature request. Let me know what you think / next steps, or if there was some other way to do what I wanted.
I am attaching an image of one of my index files for one of the projects. See how when the reporter would attempt to write an index.html file for the first folder listed, the "ng:" in the path would cause the reporter to fail.