-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assetsys: Add assetsys_mount_data()
to mount data buffers
#61
Conversation
This change attempts to tackle mattiasgustavsson#53 and adds a `assetsys_mount_data()` function to mount data from an archive data buffer. This paves the path to allow disabling STDIO, and cases in which the target already has the file loaded into memory. It splits the `assetsys_mount()` into two different internal functions to save on code duplication. These functions may or may not be named correctly: - `assetsys_internal_create_mount()`: Prepares a new mount for the assetsys instance - `assetsys_internal_mount_zip(): Iterates through the mount system and indexes the files
I think that looks great! Only thing is, I am not sure about, is the name |
|
Co-authored-by: Mattias Gustavsson <[email protected]>
Oh, I almost forgot, there's a "contributors" section near the end of the file, just before the license. Maybe add your name there (only if you want to of course). But yeah, looks good to go! |
Great! Thanks! |
This change attempts to tackle #53 and adds a
assetsys_mount_data()
function to mount data from an archive data buffer. This paves the path to allow disabling STDIO, and cases in which the target already has the file loaded into memory.It splits the
assetsys_mount()
into two different internal functions to save on code duplication. These functions may or may not be named correctly:assetsys_internal_create_mount()
: Prepares a new mount for the assetsys instanceassetsys_internal_mount_files()
: Iterates through the mount system and indexes the filesWould love your thoughts on this. Eventually, I'd like to be able to define
MINIZ_NO_STDIO
to skip cases where STDIO isn't needed.