Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simulation.py: return complex s parameter value when dB == False #32

Closed
wants to merge 0 commits into from

Conversation

laberge1
Copy link
Contributor

@laberge1 laberge1 commented Nov 7, 2020

I updated the s_param function in the Simulation class to allow it to pass complex values. When "dB" is False, instead of taking the absolute value of "s" and returning it, it just returns the complex value. This is helpful is phase information is desired.

I also ran "black --line-length 79 simulation.py" on the modified file. It does look like that compressed the unused documentation strings in each function onto a single line.

@matthuszagh
Copy link
Owner

Hm, I can't figure out why black is doing that for you. It doesn't for me, and if I change a docstring to be all one line (i.e., """"""), it doesn't change that either. My version's a bit old (19.10b0), so maybe that's it. What version are you using? In any event, sorry to keep sending you back for changes, but if you could just get rid of the docstring changes then we should be good to go.

@laberge1
Copy link
Contributor Author

laberge1 commented Nov 8, 2020

No worries! Thank you for letting me contribute.

I am using version 20.8b1. In looking through issues, it appears that this one may have resulted in the issues that we are seeing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants