Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SQL Server support #94

Closed
wants to merge 3 commits into from
Closed

Added SQL Server support #94

wants to merge 3 commits into from

Conversation

cjheath
Copy link

@cjheath cjheath commented Sep 7, 2012

SQL Server support working nicely - just needed the right query to extract the FK schema.

@tboerger
Copy link

When will this pull request be available? I need SQL Server support for a project.

@cjheath
Copy link
Author

cjheath commented Dec 19, 2012

tboerger: This project seems to have been orphaned - the author neither accepts, rejects, nor even acknowledges pull requests. Time for a new maintainer (no, I'm not volunteering)? Meantime you can include this in your Gemfile:

gem "foreigner", :git => "git://github.com/cjheath/foreigner.git"

@cleblanc87
Copy link

👍 merge would be nice

@matthuhiggins
Copy link
Owner

It has not been orphaned, I'm just lazy. I have had this come around a few times. I have also had requests for Oracle and other adapter support. A long while ago, I added the ability to register an adapter, so that this code does not go into the foreigner gem.

@cjheath
Copy link
Author

cjheath commented Jan 23, 2013

You spent more time writing that reply than it would have taken to hit the "Merge" button :(.

Behaviour like that is what makes me say you've orphaned it.

@tboerger
Copy link

@cjheath I hope you will notice when you drop your clone. When you will do that i've got to install an alternative.

@cleblanc87
Copy link

I've extracted cj's code to a gem https://github.com/cleblanc87/sqlserver-foreigner

@cjheath if you'd like to take over ownership of the gem, let me know

@jenseng
Copy link
Contributor

jenseng commented Jan 24, 2013

@cleblanc87 lol, i am a minute too late ... i was just about to suggest that @cjheath create a foreigner-sqlserver gem

@tboerger
Copy link

Thank you guys. You should add a link to the repository to gemcutter https://rubygems.org/gems/sqlserver-foreigner ;)
Added this gem to my project 👯

@matthuhiggins
Copy link
Owner

Thanks guys, and sorry for being anal about what gets in. Been maintaining this for a few years and I know that if I let all the little things add up, I won't want to maintain it anymore.

I added a reference to your gem in the README.

@cjheath
Copy link
Author

cjheath commented Feb 1, 2013

On 25/01/2013, at 3:34 AM, Chris [email protected] wrote:

I've extracted cj's code to a gem https://github.com/cleblanc87/sqlserver-foreigner
@cjheath if you'd like to take over ownership of the gem, let me know

Well, given that I'm still extending both it and foreigner (see my fork of foreigner),
I probably should… but really the new gem should have been named foreigner-sqlserver
rather than the other way around.

Anyhow I doubt we can make any changes while ruby gems.org woes continue :)

Thanks Chris - ping me directly at [email protected] to arrange things.

Clifford Heath.

@jetheredge
Copy link

I'm interested in the sqlserver-foreigner gem, have you guys decided if you're going to fork the gem or if you're going to create another 'foreigner-sqlserver' gem? Any updates would be awesome, and let me know if I can help in any way.

@matthuhiggins
Copy link
Owner

@jetheredge Does the gem made by @cleblanc87 work for you?

@jetheredge
Copy link

@matthuhiggins Yep, I believe that it will work for me. It looks like @cjheath is doing active development in his branch, so I just wanted to make sure that I was referencing the most "likely to be kept current" gem.

@cjheath
Copy link
Author

cjheath commented Feb 7, 2013

I intend to manage a gem, which should be called foreigner-sqlserver, and will contain my latest, along with Chris's packaging. My changes the other day were around ON UPDATE actions, since you can have FKs that don't point at the surrogate keys... in my fork which we're still using, since I haven't gemify'd them yet.

@cleblanc87
Copy link

@cjheath it looks like you are going beyond the scope of what I packaged, perhaps it would be best to leave https://github.com/cleblanc87/sqlserver-foreigner as just a gem that registers sqlserver (as it currently does)?

@cjheath
Copy link
Author

cjheath commented Feb 8, 2013

I've released foreigner-sqlserver, which lives at http://github.com/cjheath/foreigner-sqlserver

If you use cascading updates (for FKs onto non-PKs) then it needs the "updates cascade" patch from my foreigner repo, which unfortunately I included in another commit; will fix that and send a pull request.

An example of when you might use this is if you have an ISO3166 country table, with name, 2-char code, 3-char code, ISO numeric code, and a PK. You might wish some FKs to use one of the codes instead of the PK, to avoid extra joins in your apps. I do :).

@jetheredge
Copy link

@cjheath Thank you, I'll check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants