Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split on preserved comments before running minification, fixes #222 #320

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

split on preserved comments before running minification, fixes #222 #320

wants to merge 3 commits into from

Commits on Mar 22, 2020

  1. fixes matthiasmullie#222 and matthiasmullie#280 

    uses Tim Hunt's regex fix for matthiasmullie#333, but moves it so it's done
in a different place to split on, rather than remove, special comments
    David Scotson committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    f14ce7d View commit details
    Browse the repository at this point in the history

  2. speed/memory optimisations

    David Scotson authored and David Scotson committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    279046f View commit details
    Browse the repository at this point in the history

  3. tweak for matthiasmullie#301, unnecessary regex? 

    It's not clear if both of these are necessary, the second one should
just match everything the first one matches plus things within internal
lines, so it seems redundant.

The unit test commited with it, plus all the others still pass, and
there's no diff in the output on a long test file.
    David Scotson committed Mar 22, 2020
    Configuration menu
    Copy the full SHA
    969f084 View commit details
    Browse the repository at this point in the history