Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require unittest.mock instead of mock #54

Closed
pgajdos opened this issue Apr 6, 2022 · 3 comments · Fixed by #71
Closed

require unittest.mock instead of mock #54

pgajdos opened this issue Apr 6, 2022 · 3 comments · Fixed by #71

Comments

@pgajdos
Copy link

pgajdos commented Apr 6, 2022

Could you please consider to use unittest.mock instead of mock, as fallback at least?

@dvzrv
Copy link

dvzrv commented Nov 13, 2022

Hi! I'm packaging this project for Arch Linux and would also very much like to see this happen.
Is there a particular reason to still offer support for python 2.7? Only with python >= 3.3 unittest.mock is available and it's possible to replace mock (entirely). If backwards compatibility should still be guaranteed, it would need to be done via a conditional import.

In general it would be advisable to not support versions outside of the officially supported Python versions though, as that guarantees an easier handling of these types of dependencies (by removing them).

archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Nov 13, 2022
git-svn-id: file:///srv/repos/svn-community/svn@1347287 9fca08f4-af9d-4005-b8df-a31f2cc04f65
archlinux-github pushed a commit to archlinux/svntogit-community that referenced this issue Nov 13, 2022
git-svn-id: file:///srv/repos/svn-community/svn@1347287 9fca08f4-af9d-4005-b8df-a31f2cc04f65
@dvzrv
Copy link

dvzrv commented Jan 5, 2023

@vstoykov @matthewwithanm ping

@vstoykov
Copy link
Collaborator

Fixed in #71

vstoykov added a commit that referenced this issue Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants