workflow fork linking test

matthewhilton · Aug 9, 2024 · 4c126dd · 4c126dd
1 parent 3842ad1
commit 4c126dd
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/Installer/VendorInstaller.php b/src/Installer/VendorInstaller.php
@@ -120,13 +120,20 @@ public function installNode(): void
         }
 
         $nvmDir  = getenv('NVM_DIR');
-        $cmd     = ". $nvmDir/nvm.sh && nvm install && nvm use && echo \"NVM_BIN=\$NVM_BIN\"";
+        $cmd     = ". $nvmDir/nvm.sh";
+        $process = $this->execute->passThroughProcess(
+            Process::fromShellCommandline($cmd, $this->moodle->directory, null, null, null)
+        );
+        if (!$process->isSuccessful()) {
+            throw new \RuntimeException('nvm include failed');
+        }
 
+        $cmd     = ". $nvmDir/nvm.sh && nvm install && nvm use && echo \"NVM_BIN=\$NVM_BIN\"";
         $process = $this->execute->passThroughProcess(
             Process::fromShellCommandline($cmd, $this->moodle->directory, null, null, null)
         );
         if (!$process->isSuccessful()) {
-            throw new \RuntimeException('Node.js installation failed.');
+            throw new \RuntimeException('Node.js installation failed. Output: ' . $process->getOutput() . ' nvm dir: ' . (string) $nvmDir);
         }
         // Retrieve NVM_BIN from initialisation output, we will use it to
         // substitute right Node.js environment in all future process runs.