-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed doctree2md adding extra header level #10
base: main
Are you sure you want to change the base?
Conversation
This bug is documented in issue matthew-brett#9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this. Do the tests all pass? If so, would you mind adding a test that will fail with the old behavior and pass with the new?
By the way - I hackishly put this in here, because I had problem with multiple top-level headings, I forget where now, whether in the notebooks, or in the built Markdown. So, for full glory, I'd love a configuration flag to set whether I get the old or the new behavior.
Without my change, 5 of the tests are already failing. Apologies in advance for dumping the test stack trace here.
|
Also, could you explain why you added an extra hash in the It just seems wrong to me. nb2plots/tests/rst_md_files/subtitle.smd ## A title
### A subtitle
Some text.
### A section
More text. |
This bug is documented in issue #9