Query Changes #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alidates plugin DSL syntax)
mattflax
reviewed
Dec 17, 2018
| final Map<String, Object> configuration = Collections.emptyMap(); | ||
| final Map<String, Object> configuration = new HashMap<>(); | ||
| // Most of these don't actually apply except for plugins, but the class ExternalElastic extends expects them | ||
| configuration.put("path.home", "/tmp"); |
There was a problem hiding this comment.
Could the value for path.home be changed to System.getProperty("java.io.tmpdir"), for consistency across OSes. I appreciate it probably doesn't cause a directory to be created, but if we do decide to start the ES node in future, it may do so.
mattflax
reviewed
Dec 17, 2018
| @@ -97,6 +108,7 @@ public void beforeStart(final Map<String, Object> configuration) { | |||
| .put("path.logs", logsFolder.getAbsolutePath()) | |||
| .put("path.data", dataFolder.getAbsolutePath()) | |||
| .put("cluster.name", "rre_" + System.currentTimeMillis()); | |||
|
|
|||
There was a problem hiding this comment.
I'd be inclined to move the RRENode instantiation/settings build into its own method, so you don't need to do the whole beforeStart() method when you call from ExternalElasticsearch - eg. buildRreNode(configuration) or simiilar. That will avoid redundant folders being created.
| @@ -37,7 +38,8 @@ | |||
|
|
|||
| @Override | |||
| public void beforeStart(Map<String, Object> configuration) { | |||
| // No-op for this implementation | |||
| // Need RRE node instantiated to get plugin info (This does not start the node) | |||
| super.beforeStart(configuration); | |||
There was a problem hiding this comment.
As mentioned above, if we can avoid calling the full beforeStart method, I think we should.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses XContentParser to parse queries which adds compatibility for things like rescore and verifying the internals of an LTR query.
It does add some headache if you just want to get things working using an external instance, it requires that the plugins be installed local to RRE and configured in the pom file. I'm still weighing whether or not this is a good change for external, it makes sense for the internal engine.
Any thoughts? The alternative was to add another block that just parsed out a rescore object but I felt like there may be other plugins I have no idea about utilizing other keys.