Add comment to Make and tweak README.md

mattf · Sep 15, 2016 · 4a21a0c · 4a21a0c
1 parent 10feeb4
commit 4a21a0c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/openshift-spark-py27-sti/Makefile b/openshift-spark-py27-sti/Makefile
@@ -1,6 +1,10 @@
 BASE_IMAGE=centos/python-27-centos7:latest
 LOCAL_IMAGE=openshift-spark-py27-sti
-SPARK_IMAGE=myproject/openshift-spark-py27-sti
+
+# If you are going to push the built image to a registry
+# using the "push" make target then you should replace
+# "project" with an appropriate path for your registry and/or project
+SPARK_IMAGE=project/openshift-spark-py27-sti
 
 .PHONY: build clean push create destroy artifacts clean-artifacts clean-dockerfile clean-scripts clean-template
 

diff --git a/openshift-spark-py27-sti/README.md b/openshift-spark-py27-sti/README.md
@@ -12,9 +12,12 @@ the parent directory contain the same version of spark.
 
 ## How to use this Makefile
 
-The `clean`, `build`, `create`, and `destroy` targets are analagous
+The `clean`, `build`, `push`, `create`, and `destroy` targets are analagous
 to the targets in the parent directory's Makefile.
 
+By default the `push` target will tag the image as `project/openshift-spark-py27-sti`,
+edit the Makefile and change `SPARK_IAMGE` to control this.
+
 However, files must be copied from the parent directory before the
 image may be built. To do this use `make artifacts`: