-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for Global Retention policy in hours #181
Conversation
@saturninoabril I still have this marked as draft because there are tests in the pipeline failing. I'm not even sure if this is in reference to the 2 files I added as part of my PR |
…enarios hidding a bug.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...suite/system-console/compliance/data-retention-policy/SetGlobalPolicyForAttachmentInHours.md
Outdated
Show resolved
Hide resolved
...suite/system-console/compliance/data-retention-policy/SetGlobalPolicyForAttachmentInHours.md
Outdated
Show resolved
Hide resolved
...s/suite/system-console/compliance/data-retention-policy/SetGlobalPolicyForMessagesInHours.md
Outdated
Show resolved
Hide resolved
...s/suite/system-console/compliance/data-retention-policy/SetGlobalPolicyForMessagesInHours.md
Outdated
Show resolved
Hide resolved
@saturninoabril yes I see. I missed the But, I'm not seeing how tis get's me any closer, the error on my local looks the exact same :) Where is the problem? 0/5 looks like Deno (maybe through a API) is making calls to remote files and something unexpected is in the response. Is this correct or am I misunderstanding the issue? Yesterday using the Brew package manager I updated Deno. I'm not clear on what I should do next. |
I think you're on track. Have you tried applying the change requests I commented? Once applied, you may try local validation again and see if it fixes the error you're seeing. |
…-policy/SetGlobalPolicyForAttachmentInHours.md Co-authored-by: Saturnino Abril <[email protected]>
…-policy/SetGlobalPolicyForAttachmentInHours.md Co-authored-by: Saturnino Abril <[email protected]>
…-policy/SetGlobalPolicyForMessagesInHours.md Co-authored-by: Saturnino Abril <[email protected]>
…-policy/SetGlobalPolicyForMessagesInHours.md Co-authored-by: Saturnino Abril <[email protected]>
@saturninoabril Awesome thank man! Locally it's fine now so let's see. The pipeline should say the same. |
Implemented changes so default status is now correct and removed empty This is now ready for review. |
@saturninoabril can you please review once more when you have a chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @DHaussermann, LGTM!
@DHaussermann Test cases added as MM-T5627 and MM-T5628. |
Add tests for Global Retention policy in hours