Updated the readme file to remove the use of legacy app #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #375 +/- ##
=======================================
Coverage 18.04% 18.04%
=======================================
Files 9 9
Lines 1546 1546
=======================================
Hits 279 279
Misses 1216 1216
Partials 51 51 ☔ View full report in Codecov by Sentry. |
mickmister
reviewed
May 8, 2024
There was a problem hiding this comment.
@Kshitij-Katiyar Thanks for making these updates 👍 Just a few comments on wordings of things
README.md
Outdated
Comment on lines
71
to
72
| 6. Next you'll find your **Client ID** and **Client Secret**. Please copy this as these will be needed when you set up Mattermost to use the plugin. | ||
| 2. Enter a valid **Redirect URL for OAuth** \(`https://SITEURL/plugins/zoom/oauth2/complete`\) and add the same URL under **Add Allow List**. Note that `SITEURL` should be your Mattermost server URL. |
There was a problem hiding this comment.
Weird how the ordering goes from 6 to 2 here
mickmister
approved these changes
May 9, 2024
|
Docs is migrating these updates to the Mattermost Product Documentation site via mattermost/docs#7030. |
cwarnermm
added a commit
to mattermost/docs
that referenced
this pull request
May 9, 2024
mickmister
added a commit
to mattermost/docs
that referenced
this pull request
May 20, 2024
mickmister
added a commit
to mattermost/docs
that referenced
this pull request
May 30, 2024
* update github docs for mattermost/mattermost-plugin-github#762 * update zoom plugin docs for mattermost/mattermost-plugin-zoom#375 * improvements to github plugin page * remove todo comment --------- Co-authored-by: Carrie Warner (Mattermost) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary