Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MM-134] Fix issue: Emoji not working in meeting title #335

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

raghavaggarwal2308
Copy link
Contributor

Summary

Fix issue: Emoji not working in meeting title

Screenshot:

image

Ticket Link

Fixes #322 (comment)

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e22524d) 18.42% compared to head (ab62824) 18.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #335   +/-   ##
=======================================
  Coverage   18.42%   18.42%           
=======================================
  Files           9        9           
  Lines        1514     1514           
=======================================
  Hits          279      279           
  Misses       1184     1184           
  Partials       51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mickmister
Copy link
Contributor

@arush-vashishtha Can you please take a look at this PR?

Copy link
Contributor

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this PR for emoji and GiF support, working fine for all scenarios. LGTM, approved.

@mickmister mickmister added the 4: Reviews Complete All reviewers have approved the pull request label Jan 25, 2024
@mickmister mickmister merged commit 4084345 into mattermost:master Jan 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants