Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[GH-304] Update logic to post meeting link in thread when a thread is open in RHS" #329

Merged
merged 3 commits into from
Dec 28, 2023

Conversation

raghavaggarwal2308
Copy link
Contributor

Reverting on the basis of discussion on #323

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (925f6f9) 18.86% compared to head (c4f17fc) 18.86%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #329   +/-   ##
=======================================
  Coverage   18.86%   18.86%           
=======================================
  Files           9        9           
  Lines        1479     1479           
=======================================
  Hits          279      279           
  Misses       1149     1149           
  Partials       51       51           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raghavaggarwal2308
Copy link
Contributor Author

@mickmister Do we need a QA review on this PR? Or we can merge it?

@mickmister mickmister enabled auto-merge (squash) December 22, 2023 20:14
@mickmister
Copy link
Contributor

@raghavaggarwal2308 I think we can merge. It needs another merge of master

@avas27JTG avas27JTG merged commit 8f844a9 into mattermost:master Dec 28, 2023
11 checks passed
@avas27JTG avas27JTG deleted the revert-323-MM-304 branch December 28, 2023 11:12
@avas27JTG avas27JTG mentioned this pull request Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants