Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-313] Redirect user when a new meeting is started #314

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

raghavaggarwal2308
Copy link
Contributor

Summary

  • When a new meeting is started using the Zoom icon in the app bar/channel header the user is not getting redirected to the meeting tab because the meeting URL is undefined.
  • We updated the logic to convert the response of the start meeting API to JSON for fetching the meeting URL.

What to test?

  • When a user starts a new meeting using the Zoom icon in the app bar/channel header, he/she should be redirected to the meeting page.
Steps to reproduce:
  • Click on the Zoom icon in the app bar/channel header. (Note: These should not be an existing meeting of the user in that channel)
Environment:

MM version: v7.8.10
Node version: 14.18.0
Go version: 1.19.0

Ticket Link

Fixes #313

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dbbb587) 19.33% compared to head (9323ab4) 19.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   19.33%   19.33%           
=======================================
  Files           9        9           
  Lines        1479     1479           
=======================================
  Hits          286      286           
  Misses       1138     1138           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raghavaggarwal2308 raghavaggarwal2308 changed the title [MM-313] Redirect user when a new meeting is started [GH-313] Redirect user when a new meeting is started Nov 6, 2023
@mickmister mickmister added the 3: QA Review Requires review by a QA tester label Nov 8, 2023
Copy link
Contributor

@AayushChaudhary0001 AayushChaudhary0001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and approved
Working fine, LGTM

@avas27JTG avas27JTG merged commit ba2d98c into mattermost:master Nov 14, 2023
11 checks passed
@avas27JTG avas27JTG deleted the MM-313 branch November 14, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User not getting redirected to a new tab
4 participants