[GH-300]: Fixed the JS error while posting meeting link to thread view #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sue mattermost#300 (#7) * [MI-3560]: Fixed the issue mattermost#300 * [MI-3560]: Removed extra packages * [MI-3560]: Reverted the changes of package-lock.json
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #307 +/- ##
==========================================
+ Coverage 19.33% 23.51% +4.17%
==========================================
Files 9 9
Lines 1479 1212 -267
==========================================
- Hits 286 285 -1
+ Misses 1138 874 -264
+ Partials 55 53 -2
☔ View full report in Codecov by Sentry. |
mickmister
approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Great work on this @Kshitij-Katiyar 👍
LGTM, assuming getChannelIdForThread concern is addressed
AayushChaudhary0001
approved these changes
Oct 27, 2023
This was referenced Nov 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed the JS error which was caused while viewing a thread in the Threads view of the zoom plugin.
What to test?
Steps to reproduce
Environment:
MM version: v7.8.2
Node version: 14.18.0
Go version: 1.19.0
Ticket Link
Fixes #300