Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.6.2 #292

Merged
merged 8 commits into from
Apr 3, 2023
Merged

Release 1.6.2 #292

merged 8 commits into from
Apr 3, 2023

Conversation

mickmister
Copy link
Contributor

@mickmister mickmister commented Mar 27, 2023 •
edited
Loading

@mickmister mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Mar 27, 2023
@mickmister mickmister requested a review from larkox as a code owner March 27, 2023 22:00
@codecov
Copy link

codecov bot commented Mar 27, 2023 •
edited
Loading

Codecov Report

Patch coverage: 58.75% and project coverage change: +1.78 🎉

Comparison is base (9d5a119) 21.89% compared to head (8ab42cf) 23.68%.

Additional details and impacted files 
@@                Coverage Diff                @@
##           release-1.6.2     #292      +/-   ##
=================================================
+ Coverage          21.89%   23.68%   +1.78%     
=================================================
  Files                  8        9       +1     
  Lines                877     1157     +280     
=================================================
+ Hits                 192      274      +82     
- Misses               641      834     +193     
- Partials              44       49       +5
Impacted Files Coverage Δ
server/configuration.go 25.24% <ø> (-0.37%) ⬇️
server/http.go 20.27% <0.00%> (-7.59%) ⬇️
server/webhook.go 59.11% <59.11%> (ø)

... and 4 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

mickmister and others added 3 commits March 27, 2023 18:13
@mickmister
golangci
68918a0
@mickmister @mattermost-build
Implement webhook validation (#279)
82b8d41 
* move webhook handlers to its own file

* implement webhook validation

* lint

* return useful error message

* document usage of zoom's webhook secret

* PR feedback

* rename methods for readability

* add todo comment

---------

Co-authored-by: Mattermost Build <[email protected]>
@mickmister
fix merge issues
4f3e7f5
@larkox
Copy link
Contributor

larkox commented Mar 28, 2023

Why this PR has more changes than the usual bumping of the version?

@mickmister
Copy link
Contributor Author

Why this PR has more changes than the usual bumping of the version?

@larkox If we were releasing off of master, we would just be bumping the version and nothing else, but we are instead creating a dot release off of the previous release to minimize the changes and testing required for this release.

Having all of this in the same PR lets us see what we're releasing, and gives @DHaussermann a specific build to use for testing. There are some changes necessary for CI here as well.

hanzei
hanzei requested changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#294 needs to be merged first.

@mickmister mickmister requested a review from hanzei March 29, 2023 00:14
hanzei
hanzei reviewed Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should #294 get cherry-picked into the branch?

@mickmister mickmister requested a review from hanzei March 29, 2023 13:27
@mickmister mickmister removed the 2: Dev Review Requires review by a core committer label Mar 29, 2023
@mickmister
Copy link
Contributor Author

@DHaussermann This PR is ready for QA review. Note that it essentially contains only the webhook validation fix

DHaussermann
DHaussermann approved these changes Apr 3, 2023
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • Ensured webhook validation is working
  • Webhook documentation is updated for new value
  • Smoke tested the plugin
    • Start and stop a meeting
    • Use slash command as well as icon
    • End meeting and ensure the post is updated by the webhook with details
    • Collision detection is working to prevent duplicate meeting starts

An issue was found with webhook secret that is not new in this release. Created #296 to address it.

LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Apr 3, 2023
@mickmister mickmister merged commit f1b4e6c into release-1.6.2 Apr 3, 2023
@mickmister mickmister deleted the release-1.6.2-bump branch April 3, 2023 21:46
@mickmister mickmister mentioned this pull request Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHaussermann DHaussermann DHaussermann approved these changes

@hanzei hanzei hanzei approved these changes

@larkox larkox larkox approved these changes

@m1lt0n m1lt0n m1lt0n approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mickmister @larkox @m1lt0n @hanzei @DHaussermann