-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make unhandled webhook events return 200 instead of 501 #257
Conversation
Codecov Report
@@ Coverage Diff @@
## master #257 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 8 8
Lines 900 900
======================================
Misses 900 900
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@nickmisasi Looks like we have an extra event configured for our Zoom instance Thanks for implementing this fix 👍 |
@mickmister You removed Qa review label but still my name is there in the review list so could you pls tell me, should i test it or not? |
@dipak-demansol The change was trivial enough that I deemed it good to merge without QA testing |
Summary
Zoom sends webhooks for various reasons. The Mattermost Zoom Plugin only handles
meeting.ended
events. For all others, a501 - Not Implemented
status code is returned. Zoom expects a 200 or 204 response, otherwise it assumes the delivery failed and it will try again at a future time. This means that by returning a 501, Zoom will re-queue the webhook to be sent again - exasperating the issue.This has been causing us to go over alert thresholds in the Community mattermost server due to it being a 5xx error. My proposal here is to simply return a 200 in the event we don't care about a specific webhook, so that Zoom marks the delivery as successful and doesn't attempt further.
Ticket Link
n/a