dist: build linux/darwin arm64 targets #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
- Coverage 21.68% 0.00% -21.69%
==========================================
Files 8 8
Lines 853 854 +1
==========================================
- Hits 185 0 -185
- Misses 625 854 +229
+ Partials 43 0 -43
Continue to review full report at Codecov.
|
cpanato
commented
Oct 12, 2021
larkox
approved these changes
Oct 13, 2021
hanzei
approved these changes
Nov 8, 2021
server/zoom/meeting.go
Outdated
| @@ -4,7 +4,7 @@ | |||
| package zoom | |||
|
|
|||
| // Meeting is defined at https://marketplace.zoom.us/docs/api-reference/zoom-api/meetings/meeting | |||
| type Meeting struct { | |||
| type Meeting struct { // nolint: govet | |||
There was a problem hiding this comment.
What linter error does this ignore?
There was a problem hiding this comment.
a bit hard to organize the struct, if you want to try I appreciate
or maybe I'm too dumb that I cannot organize the struct
hanzei
added
4: Reviews Complete
hanzei
added
2: Dev Review
larkox
approved these changes
Nov 10, 2021
hanzei
added
4: Reviews Complete
This was referenced Nov 14, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding the linux/darwin arm64 targets, we start building arm64 for the server and will start adding the targets for the plugins for the ones we prepackage in the build
related to: mattermost/mattermost#18491
Ticket Link
related to https://mattermost.atlassian.net/browse/DOPS-633