-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate whether webhook verification should be used on deauthorize
route
#291
Comments
@mickmister I explored a bit on this issue and have some findings. If we go through the official Zoom documentation of Deauthorization, it's not specifically mentioned that we can use the new webhook validation or not but they have provided us the link to the page of webhook validation. I tried to get the deauthorize request notification from Zoom to verify if the I found this issue in which a user is saying that he is unable to match the signatures while performing the validation for deauthorization request. So according to this the header is present in the request. |
@raghavaggarwal2308 I'm thinking we should just not worry about this. We already have our own mechanism (our webhook secret) to determine the validity of the request. |
Thanks for the feedback @mickmister . Will you close this issue then? |
For the
deauthorize
feature, we are checking the legacy webhook secret, but not performing the newer webhook verification.The task here is to investigate the
deauthorize
call, to see if the Zoom webhook verification information is in the HTTP headers. See #279 for more details on the webhook verification requirements.mattermost-plugin-zoom/docs/installation/zoom-configuration/zoom-setup-oauth.md
Lines 44 to 53 in 229517f
Originally posted by @mickmister in #279 (comment)
The text was updated successfully, but these errors were encountered: