Update tokens when they get refreshed on User Level OAuth

[larkox]

Right now, on Account Level OAuth, OAuth tokens are updated when the token gets refreshed.

mattermost-plugin-zoom/server/zoom/oauth.go

Lines 101 to 120 in 2acac55

	url = fmt.Sprintf("%s/users/%s", c.apiURL, user.Email)
	currentToken, err := c.api.GetZoomSuperUserToken()
	if err != nil {
	return nil, errors.Wrap(err, "error getting zoom super user token")
	}
	tokenSource := c.config.TokenSource(context.Background(), currentToken)
	updatedToken, err := tokenSource.Token()
	if err != nil {
	return nil, errors.Wrap(err, "error getting token from token source")
	}
	if updatedToken.AccessToken != currentToken.AccessToken {
	kvErr := c.api.SetZoomSuperUserToken(updatedToken)
	if kvErr != nil {
	return nil, errors.Wrap(kvErr, "error setting new token")
	}
	}
	c.token = updatedToken

This should be also done for User Level Apps. Also, it would be nice to check if all paths are correctly updating all the tokens (User Level and Account Level).

[jupriano]

​func​ (​c​ ​*​OAuthClient​) ​getUserViaOAuth​(​user​ ​*​model.​User​) (​*​User​, ​error​) { 
​        ​url​ ​:=​ ​fmt​.​Sprintf​(​"%s/users/me"​, ​c​.​apiURL​) 
​        ​currentToken​, ​err​ ​:=​ ​c​.​api​.​GetZoomSuperUserToken​() 
​         if​ ​err​ ​!=​ ​nil​ { 
​         ​   return​ ​nil​, ​errors​.​Wrap​(​err​, ​"error getting zoom super user token"​) 
​         } 
         ​tokenSource​ ​:=​ ​c​.​config​.​TokenSource​(​context​.​Background​(), ​currentToken​) 
​        ​updatedToken​, ​err​ ​:=​ ​tokenSource​.​Token​() 
​        ​if​ ​err​ ​!=​ ​nil​ { 
​            ​return​ ​nil​, ​errors​.​Wrap​(​err​, ​"error getting token from token source"​) 
​        } 
​        ​if​ ​updatedToken​.​AccessToken​ ​!=​ ​currentToken​.​AccessToken​ { 
​           ​kvErr​ ​:=​ ​c​.​api​.​SetZoomSuperUserToken​(​updatedToken​) 
           if​ ​kvErr​ ​!=​ ​nil​ { 
​                 ​return​ ​nil​, ​errors​.​Wrap​(​kvErr​, ​"error setting new token"​) 
​           } 
​       } 
       ​c​.​token​ ​=​ ​updatedToken
​       ​if​ ​c​.​isAccountLevel​ { 
​          ​url​ ​=​ ​fmt​.​Sprintf​(​"%s/users/%s"​, ​c​.​apiURL​, ​user​.​Email​)   ​
​        } 

Is it good to update like that ? @larkox

[larkox]

This seems the functionality for the account level oauth, not for the user level oauth. Feel free to create a PR so we can look better at the changelog.

[raghavaggarwal2308]

@mickmister I think this issue has been fixed with PR #253. Can you please confirm that? If yes, can we close this issue?