-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use StoreTTL in place of Store for managing OAuth2 state #83
Conversation
Codecov Report
@@ Coverage Diff @@
## master #83 +/- ##
=======================================
Coverage 25.31% 25.31%
=======================================
Files 61 61
Lines 2303 2303
=======================================
Hits 583 583
Misses 1654 1654
Partials 66 66 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks! 🎉
@mickmister The state of the OAuth has to live from the moment the user hits the link, until the login process is finished. Therefore, you have to take in account the time the user takes to put their credentials. I think 5 minutes is a reasonable time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd choose 15m myself, but 5 seems alright, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks @avddvd!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed
- Regression tested authentication with multiple users
- Ensure authentication records are not accruing in the KV store
- Ensured time to live is respected
LGTM!
Thanks @avddvd for this improvement. Sorry for the delay on getting this tested.
/update-branch |
Thanks @avddvd! |
@avddvd Make sure to join the community server to work more closely with the team! We have a channel for this project on the server. |
Summary
Ticket Link
Fixes #71