Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct prefix for OAuth2 store keys #78

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Use correct prefix for OAuth2 store keys #78

merged 1 commit into from
Apr 8, 2020

Conversation

mickmister
Copy link
Contributor

Summary

The oauth2_store was saving its values with the key prefix sub_ when it should be using oauth2_

Ticket Link

Fixes #77

@mickmister mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Apr 8, 2020
@mickmister mickmister requested review from levb and larkox April 8, 2020 01:45
@mickmister mickmister changed the title Fix OAuth store key Use correct prefix for OAuth2 store keys Apr 8, 2020
larkox
larkox approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@levb levb added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Apr 8, 2020
@levb levb merged commit 4a84e35 into master Apr 8, 2020
@levb levb deleted the GH-77-oauth-store-key branch April 8, 2020 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larkox larkox larkox approved these changes

@levb levb levb approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OAuth store is saving to subscription key namespace
3 participants
@mickmister @levb @larkox