Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-21689] Handle timezone complications between Go and Microsoft Graph #25

Merged
merged 15 commits into from
Jan 30, 2020
Merged

[MM-21689] Handle timezone complications between Go and Microsoft Graph #25

merged 15 commits into from
Jan 30, 2020

Commits on Jan 24, 2020

  1. implement bot.Logger

    @mickmister
    mickmister committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    4b22ea7 View commit details
    Browse the repository at this point in the history

  2. handle timezones for user supplied dates and dates that need to be fo… 

    …rmatted for display

fix test

update mocks
    @mickmister
    mickmister committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    45bf064 View commit details
    Browse the repository at this point in the history

  3. use a map to do timezone conversions 

    test date time conversion
    @mickmister
    mickmister committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    699dc70 View commit details
    Browse the repository at this point in the history

  4. fix shadow

    @mickmister
    mickmister committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    dee8656 View commit details
    Browse the repository at this point in the history

  5. put comment explaining timezone conversion data

    @mickmister
    mickmister committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    45515c5 View commit details
    Browse the repository at this point in the history

  6. add another comment for conversion

    @mickmister
    mickmister committed Jan 24, 2020
    Configuration menu
    Copy the full SHA
    8d3242c View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2020

  1. address PR feedback: 

    * make utils/tz package
* convert mapping array to a map available at compile-time to avoid map creation at run-time
* unit test for testing go-compatibility of all timezones in conversion map
* some renaming
    @mickmister
    mickmister committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    97cb3c3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into timezones

    @mickmister
    mickmister committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    f8aa82f View commit details
    Browse the repository at this point in the history

  3. lint

    @mickmister
    mickmister committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    60e5249 View commit details
    Browse the repository at this point in the history

  4. go mod tidy

    @mickmister
    mickmister committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    d582a0d View commit details
    Browse the repository at this point in the history

  5. extract getRemoteUserID

    @mickmister
    mickmister committed Jan 27, 2020
    Configuration menu
    Copy the full SHA
    7b1303a View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2020

  1. change timezone function names to be shorter

    @mickmister
    mickmister committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    d4851dc View commit details
    Browse the repository at this point in the history

  2. use conversions from time library's map

    @mickmister
    mickmister committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    5c15e99 View commit details
    Browse the repository at this point in the history

  3. address PR feedback: 

    * rename ConvertToTimezone -> In
* inline tz.Go()
* rename remote.NewMicrosoftDateTime -> remote.NewDateTime
* rename common.go -> date_time.go
* remove tz package alias
* use URL builder
    @mickmister
    mickmister committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    7a76d8b View commit details
    Browse the repository at this point in the history

  4. move timezone data to tz/data.go

    @mickmister
    mickmister committed Jan 28, 2020
    Configuration menu
    Copy the full SHA
    5b519c9 View commit details
    Browse the repository at this point in the history