-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MM-39399] Bump min_server_version due to imported server dependency breaking changes #236
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we bump the minimum server version to 5.37 to fix this issue? 5.36 is a quite old version that isn't supported any longer according to https://docs.mattermost.com/upgrade/extended-support-release.html.
Do we need a patch release? |
Codecov Report
@@ Coverage Diff @@
## master #236 +/- ##
=======================================
Coverage 23.80% 23.80%
=======================================
Files 62 62
Lines 2541 2541
=======================================
Hits 605 605
Misses 1857 1857
Partials 79 79 Continue to review full report at Codecov.
|
Closing in favor of mattermost/mattermost-marketplace#233 |
Don't we want to bump the |
Repoening, as the fix still needs to be applied here, and not just the marketplace. |
Let's simply merge this as the fix is straight forward. |
Summary
There is a breaking change with
5.37
server code, where the plugin will crash if:5.37
or later5.36
or beforeThis PR downgrades the dependencies of
mattermost-plugin-api
andmattermost-server
. The only change to the plugin source code is a change in the constructor of thepluginapi.Client
. We are no longer accessing aplugin.Driver
struct to pass to this constructor.The dependency was originally bumped for the license check. The license check code is very small and has no dependencies, so I copied some code over to this repo to avoid the greater dependency. The license check is still the correct logic.
Edit: I've changed the PR so it just updates the
min_server_version
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-39399