Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify version for mockgen package #232

Merged
merged 5 commits into from
Oct 26, 2021
Merged

Specify version for mockgen package #232

merged 5 commits into from
Oct 26, 2021

Conversation

mickmister
Copy link
Contributor

Summary

See #213 (comment)

@mickmister mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Sep 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #232 (94e035f) into master (9411708) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #232   +/-   ##
=======================================
  Coverage   23.80%   23.80%           
=======================================
  Files          62       62           
  Lines        2541     2541           
=======================================
  Hits          605      605           
  Misses       1857     1857           
  Partials       79       79           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9411708...94e035f. Read the comment docs.

@mickmister
Copy link
Contributor Author

@hanzei The linter is complaining and saying that go mod tidy needs to be run. When I run go mod tidy, the original error returns:

go install github.com/golang/mock/mockgen
../../../../pkg/mod/github.com/golang/[email protected]/mockgen/parse.go:35:2: missing go.sum entry for module providing package golang.org/x/tools/go/packages (imported by github.com/golang/mock/mockgen); to add:
        go get github.com/golang/mock/[email protected]
make: *** [mock] Error 1

I'm not sure what needs to be done here

go.sum Outdated Show resolved Hide resolved
@mickmister mickmister changed the title Add mockgen to go.sum Specify version for mockgen package Sep 24, 2021
@hanzei hanzei removed the 2: Dev Review Requires review by a core committer label Sep 27, 2021
@hanzei hanzei added this to the v1.2.0 milestone Sep 27, 2021
@hanzei
Copy link
Collaborator

hanzei commented Oct 26, 2021

Let's skip QA review as this is only a build tooling change.

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Oct 26, 2021
@hanzei hanzei merged commit 2f66ad9 into master Oct 26, 2021
@hanzei hanzei deleted the add-mockgen-go-sum branch October 26, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants