Remove mail permissions, add mailbox setting permission #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickmister
added
2: Dev Review
Codecov Report
@@ Coverage Diff @@
## master #222 +/- ##
=======================================
Coverage 23.75% 23.76%
=======================================
Files 64 64
Lines 2627 2626 -1
=======================================
Hits 624 624
+ Misses 1920 1919 -1
Partials 83 83
Continue to review full report at Codecov.
|
larkox
approved these changes
Jul 7, 2021
|
@mickmister Heads up that you need to fix the tests. |
DHaussermann
approved these changes
Sep 7, 2021
There was a problem hiding this comment.
This change should not have any impact. The setup should work the same with the existing instruction set.
This will be covered in v1.1.0 release testing.
@mickmister please merge.
mickmister
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the request for
Mail.ReadandMail.Sendpermissions since the plugin never reads or sends mail. I believe this was a preemptive decision to include these permissions in case we would need to read mail in the future, but currently yagni.We haven't documented the need for this permission because the plugin doesn't need it, and I'm not sure how installations have worked without having that granted, since the user connect process should have been blocked by Microsoft.
This also adds the request for
MailboxSettings.Readsince that is required to get the user's timezone information.Ticket Link
Fixes #221