Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use limit 20 for calendar events API call #178

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Use limit 20 for calendar events API call #178

merged 2 commits into from
Aug 5, 2020

Conversation

mickmister
Copy link
Contributor

Summary

By default, the msgraph API returns a maximum of 10 calendar events. This PR makes it so we request 20 events instead.

Ticket Link

#171

@mickmister mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Jul 21, 2020
@mickmister mickmister requested review from levb and larkox July 21, 2020 21:04
@larkox larkox removed the 2: Dev Review Requires review by a core committer label Jul 22, 2020
@larkox larkox requested a review from DHaussermann July 22, 2020 07:31
@mickmister mickmister linked an issue Aug 4, 2020 that may be closed by this pull request
Summary view only shows first 10 events for the day if there are more than 10 #171
Closed
DHaussermann
DHaussermann approved these changes Aug 4, 2020
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed.

  • All events of the day are shown if there are 20 or less
  • This is resolved for both viewcal and summary view
    LGTM!

Added release test to cover this.

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Aug 4, 2020
@mickmister mickmister merged commit 61581f3 into master Aug 5, 2020
@mickmister mickmister deleted the calendar-events-20-count branch August 5, 2020 00:30
@mickmister mickmister mentioned this pull request Mar 19, 2021
Merged
@mickmister mickmister mentioned this pull request Oct 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHaussermann DHaussermann DHaussermann approved these changes

@larkox larkox larkox approved these changes

@levb levb levb approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Summary view only shows first 10 events for the day if there are more than 10
4 participants
@mickmister @levb @larkox @DHaussermann