Order daily summary view #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iomodo
approved these changes
Jul 21, 2020
mickmister
approved these changes
Jul 29, 2020
mickmister
added
3: QA Review
DHaussermann
approved these changes
Aug 4, 2020
There was a problem hiding this comment.
Tested and passed
strangely this did not repro for me every time, but it seems resolved now.
- Created a batch of 12 meeting ensuring that multiple of the meetings were created in non-chronological order
- Observed 1 occurrence where events are incorrectly sorted by creation date and applied the PR
- Both
viewcalandsummary viewnow show all events in chronological order
LGTM!
Added release test to cover this.
DHaussermann
added
4: Reviews Complete
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Order the events slice by start date before showing it in the summary view. It seems that the default is ordered by end date instead.
Ticket Link
Fix #175