[GH-153] Receive notifications of new events get's set to No even when I select Yes on login flow #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…during welcome flow
larkox
added
2: Dev Review
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
==========================================
+ Coverage 23.51% 23.53% +0.01%
==========================================
Files 62 62
Lines 2513 2511 -2
==========================================
Hits 591 591
+ Misses 1848 1846 -2
Partials 74 74
Continue to review full report at Codecov.
|
mickmister
approved these changes
Jun 3, 2020
levb
approved these changes
Jun 3, 2020
DHaussermann
approved these changes
Jun 10, 2020
There was a problem hiding this comment.
Tested and passed
- I have reviewed my local affected users and the issue is resolved for them.
- This issue did not reproduce for me on any other servers
LGTM!
Thanks @larkox
DHaussermann
added
4: Reviews Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the situation where some users do not set the "Receive notifications of new events" even if they clicked yes during the login.
Ticket Link
Fix #153