-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EE license check #151
Add EE license check #151
Conversation
go.mod
Outdated
@@ -7,7 +7,7 @@ require ( | |||
github.com/gorilla/mux v1.7.3 | |||
github.com/jarcoal/httpmock v1.0.4 | |||
github.com/mattermost/mattermost-plugin-api v0.0.9 | |||
github.com/mattermost/mattermost-server/v5 v5.3.2-0.20200313113657-e2883bfe5f37 | |||
github.com/mattermost/mattermost-server/v5 v5.24.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could some commit on master
be used instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was discussed on a different conversation. We will point to master, merge this, and whenever 5.24 is addressable, we will update the plugin to address the correct server version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
=======================================
Coverage 23.51% 23.51%
=======================================
Files 62 62
Lines 2513 2513
=======================================
Hits 591 591
Misses 1848 1848
Partials 74 74 Continue to review full report at Codecov.
|
@aaronrothschild according to this conversation we discussed about checking for LDAP until we start using 5.24. Should that check be done in this PR? |
I tested this. When it does not start the following is logged:
|
Regarding the log message, what about |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed
- This is working as expected.
- Change suggestion above has been implemented
Summary
Add license check on plugin activate.
IMPORTANT: This require v5.24.0 of mattermost-server which is not yet released. Therefore, the package cannot be imported, and go.sum has not been properly updated. Probably this PR needs an update when v5.24.0 is in place.
Ticket Link
None