Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove references to "common" #122

Merged
merged 2 commits into from
May 19, 2020
Merged

Remove references to "common" #122

merged 2 commits into from
May 19, 2020

Conversation

mickmister
Copy link
Contributor

@mickmister mickmister commented May 6, 2020 •
edited
Loading

Summary

A made a PR for this a while ago but missed the plugin.json file.

Ticket Link

Fixes #114

@mickmister mickmister added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels May 6, 2020
@levb
Copy link
Contributor

levb commented May 7, 2020

Just for my understanding, do we still support personal Outlook.com accounts? Just removing the confusing references? Or is it no longer supported at all?

@mickmister
Copy link
Contributor Author

@levb I believe it is not supported now, though I haven't once tried to set it up that way. It this a a use case we want to support?

larkox
larkox approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@larkox larkox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mickmister mickmister removed the 2: Dev Review Requires review by a core committer label May 8, 2020
DHaussermann
DHaussermann approved these changes May 19, 2020
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and passed

  • common removed from Admin side description and field default.
  • No additional functional testing needed.

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels May 19, 2020
@mickmister
Copy link
Contributor Author

/update-branch

@codecov-commenter
Copy link

Codecov Report

Merging #122 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   24.67%   24.67%           
=======================================
  Files          65       65           
  Lines        2545     2545           
=======================================
  Hits          628      628           
  Misses       1841     1841           
  Partials       76       76

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0013cc5...3725114. Read the comment docs.

@mickmister mickmister merged commit 87df7e5 into master May 19, 2020
@mickmister mickmister deleted the remove-common-refs branch May 19, 2020 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHaussermann DHaussermann DHaussermann approved these changes

@larkox larkox larkox approved these changes

@levb levb levb approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove mentions of common deployment that does not use Azure AD
6 participants
@mickmister @levb @codecov-commenter @larkox @DHaussermann @mattermod