Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH104] Check when the error when cleaning a setting post is not found #105

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

larkox
Copy link
Contributor

@larkox larkox commented Apr 27, 2020

Summary

Remove the server error that occurred when a new user opened the settings panel, and there was no previous panel to delete. This was caused by not handling the "not found" error of the store.

Ticket Link

#104

@larkox larkox requested a review from levb April 27, 2020 15:14
@larkox larkox requested a review from mickmister as a code owner April 27, 2020 15:14
@larkox larkox added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Apr 27, 2020
@larkox larkox linked an issue Apr 27, 2020 that may be closed by this pull request
Copy link
Contributor

@levb levb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check when the error when cleaning a setting post is not found the title doesn't make much sense? Otherwise LGTM :)

@mickmister mickmister removed the 2: Dev Review Requires review by a core committer label Apr 28, 2020
@mickmister mickmister merged commit cfe0d0b into mattermost:master Apr 28, 2020
@levb levb added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"could not clean previous setting post" error showing on clean users
3 participants