Release 3.2.5 #937
Release 3.2.5 #937
Conversation
After some name changing, MM_RUDDER_WRITE_KEY has become MM_RUDDER_PLUGINS_PROD.
Fixes hook race condition for telemetry (onactivate, onconfigchanged) mattermost-server and pluginapi deps have been updated, opengraph forced as an indirect dep to avoid a ambiguous dep conflict
Configure telemetry fixes locally to avoid increasing min_server_version (rollbacked to 6.5.2) This fixes the problems introduced by #930. This locally copied telemetry package can be removed in favor of [email protected] when we can safely upgrade min_server_version to 7.4. Fixes https://mattermost.atlassian.net/browse/MM-51548
| @@ -539,7 +539,6 @@ func (p *Plugin) httpGetJiraProjectMetadata(w http.ResponseWriter, r *http.Reque | |||
| } | |||
| } | |||
|
|
|||
| type option = utils.ReactSelectOption | |||
There was a problem hiding this comment.
I did this in addition to the cherry-pick because the linter complained.
trilopin
added
2: Dev Review
| @@ -2625,7 +2625,7 @@ | |||
| "amdefine": { | |||
| "version": "1.0.1", | |||
| "resolved": "https://registry.npmjs.org/amdefine/-/amdefine-1.0.1.tgz", | |||
| "integrity": "sha1-SlKCrBZHKek2Gbz9OtFR+BfOkfU=", | |||
| "integrity": "sha512-S2Hw0TtNkMJhIabBwIojKL9YHO5T0n5eNqWJ7Lrlel/zDbftQpxpapi8tZs3X1HWa+u+QeydGmzzNU0m09+Rcg==", | |||
There was a problem hiding this comment.
Accidental changes? Maybe part of cherrypick though
There was a problem hiding this comment.
I ran full make deploy after the merge to ensure everything works together, and npm never misses the opportunity to make some changes.
about integrity hashes, should we ignore that?
There was a problem hiding this comment.
about integrity hashes, should we ignore that?
I'm honestly not sure. @hmhealey Do you have any thoughts on this? Using sha512 is certainly more thorough than sha1. I'm mainly wondering if we should converge on the sha512 hashes all around to make sure unintentional lock file changes like this are avoided. (Sorry I always mention you for npm questions/conventions)
There was a problem hiding this comment.
No worries on the mention since I've spent so much time trying to understand the chaos of npm 😛
As long as they're not changing back and forth, I think we can be fine with whatever. Based on this, npm's been using sha512 for a few years now, and the web app's package-lock has all sha512 hashes as well. I'd assume those previous hashes were from an older version of npm
There was a problem hiding this comment.
Tested and passed
-
Looked over the branch and only telemetry changes are implemented
-
No functional testing needed for any changes form my side
-
Quick smoke test as a precaution
- Installed instance
- Connect / disconnect
- Create an attach issue work
- Spot check slash commands
- Issue subscriptions are functional
- As precaution, ensure the build from the pipeline starts and runs on a cloud server
LGTM! thanks @trilopin
DHaussermann
added
4: Reviews Complete
Summary
Fixes
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-52608