-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add built info via /jira about #916
Conversation
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #916 +/- ##
==========================================
- Coverage 31.18% 31.16% -0.02%
==========================================
Files 50 50
Lines 7405 7409 +4
==========================================
Hits 2309 2309
- Misses 4905 4909 +4
Partials 191 191
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM, just one request to change /jira info
to /jira me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed
info
has been removed- Details from
info
have now been split intoabout
andme
- Confirmed the new commands are not restricted by MM role as I would expect
No issues found.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and passed
info
has been removed- Details from
info
have now been split intoabout
andme
- Confirmed the new commands are not restricted by MM role as I would expect
No issues found.
LGTM!
Summary
Make use of mattermost/mattermost-plugin-api#121. See mattermost/mattermost-plugin-github#598 and mattermost/mattermost-plugin-gitlab#362.
The PR also split the built info from
/jira info
into a separate/jira about
. This has the benefit of/jira about
only containing non -confidential information, which can be used in an issue report.Ticket Link
None