Fix config auto unmarshalling #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
- Coverage 86.29% 78.37% -7.92%
==========================================
Files 3 4 +1
Lines 124 148 +24
==========================================
+ Hits 107 116 +9
- Misses 9 22 +13
- Partials 8 10 +2
Continue to review full report at Codecov.
|
This was referenced Dec 22, 2018
jwilander
approved these changes
Dec 22, 2018
lieut-data
approved these changes
Dec 22, 2018
hanzei
added
4: Reviews Complete
hanzei
added a commit
to mattermost/mattermost-plugin-zoom
that referenced
this pull request
Dec 23, 2018
lindy65
removed
the
4: Reviews Complete
avas27JTG
pushed a commit
that referenced
this pull request
Mar 8, 2024
… url (#870) * [MI-2154]:Fixed issue(768) /Jira Connect doesn't open mattermost's subpath url (#3) * Fixes #768 * Update webapp/src/actions/index.ts updated the url to use string interpolation syntax. Co-authored-by: Michael Kochell <[email protected]> * updated with feedback from Michael * removed the unwanted styles changes * removed the unwanted styles changes * removed the unwanted styles changes * resolved comments * resolved comments * plugin now adds the entire url from the config * connect to cloud with subpath now working * fixed styling and linting issues * fixed linting issue * Update server/user_cloud.go Co-authored-by: Michael Kochell <[email protected]> * updated method to call the site url with a sub path * updated method to call the site url with a sub path * updated logic based on lev's comments * added a method in plugin.go that will generate the final path * updated based on feedback from levb * added method to generate full path * fixed conflicts * updated and tested connect * Update index.ts removed whitespace * Update webpack.config.js * updated SiteURL handler * [MI-2154]:fixed lint errors * [MI-2154]:fixed review fixes Co-authored-by: Sanjay <sanjaymj@12345> Co-authored-by: Maisnam Raju Singh <[email protected]> Co-authored-by: Michael Kochell <[email protected]> Co-authored-by: maisnamrajusingh <[email protected]> * [MM-768]:fixed CI error * Improved code quality (#5) * Review fixes done * [MI-2182]: Review fixes done 1. Improved code quality * [MI:2182]:Review fixes done 1.Improved code quality * Review fixes done of #870 (#13) * Review fixes done * [MI-2182]: Review fixes done 1. Improved code quality * [MI:2182]:Review fixes done 1.Improved code quality * [MI-2182]: Review fixes done 1.Improved code quality * [MI-2182]:Fixed CI errors * [MM-768]:Fixed review comment * [MI-2839]: Done the review fixes of a Jira PR #870 (#41) * [MI-2839]: Done the review fixes of a Jira PR #887 * [MI-2839]: Review fixes done 1.Changed the way to create a full URL path --------- Co-authored-by: Sanjay <sanjaymj@12345> Co-authored-by: Maisnam Raju Singh <[email protected]> Co-authored-by: Michael Kochell <[email protected]> Co-authored-by: maisnamrajusingh <[email protected]> Co-authored-by: Nityanand Rai <[email protected]> Co-authored-by: Nityanand Rai <[email protected]> Co-authored-by: raghavaggarwal2308 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://mattermost.atlassian.net/browse/MM-13581