Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-61118] Add diagnostics data to the Support Packet #837

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[MM-61118] Add diagnostics data to the Support Packet #837

wants to merge 8 commits into from
+56 −9

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Oct 16, 2024 •
edited
Loading

Summary

When a Support Packet gets generated, the plugin now includes diagnostics data via a diagnostics.yaml file into the Packet.

Example content of github/diagnostics.yaml:

version: 2.3.0+6ba0bcd
connected_user_count: 1
is_oauth_configured: true

Requires mattermost/mattermost#28833 on the server side.

See https://mattermost.atlassian.net/wiki/spaces/CLOUD/pages/3083108354/Diagnostics+data+from+Core+Plugins+to+the+Support+Packet for more context.

Ticket Link

https://mattermost.atlassian.net/browse/MM-61119

@hanzei hanzei added the Work In Progress Not yet ready for review label Oct 16, 2024
@hanzei hanzei added this to the v2.4.0 milestone Nov 4, 2024
@hanzei hanzei marked this pull request as ready for review November 4, 2024 11:56
@hanzei hanzei requested a review from wiggin77 as a code owner November 4, 2024 11:56
@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester and removed Work In Progress Not yet ready for review labels Nov 4, 2024
@hanzei
Copy link
Contributor Author

hanzei commented Nov 11, 2024

@wiggin77 @Kshitij-Katiyar Gentle reminder to review the PR 😉

wiggin77
wiggin77 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hanzei
Copy link
Contributor Author

hanzei commented Nov 14, 2024

@AayushChaudhary0001 Can you please review the PR? QA steps are in the ticket. Let me know if you need anything from me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiggin77 wiggin77 wiggin77 approved these changes

@Kshitij-Katiyar Kshitij-Katiyar Awaiting requested review from Kshitij-Katiyar

@AayushChaudhary0001 AayushChaudhary0001 Awaiting requested review from AayushChaudhary0001

Assignees
No one assigned
Labels
2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@hanzei @wiggin77